From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOXKJ-0005BG-N5
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:36:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOXKE-00057p-Ud
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:36:47 -0400
Received: from [199.232.76.173] (port=60187 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOXKE-00057k-Gx
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:36:42 -0400
Received: from mx1.redhat.com ([66.187.233.31]:60550)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1MOXAM-0007yv-BR
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:26:30 -0400
Date: Wed, 8 Jul 2009 14:26:23 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot
Message-ID: <20090708132623.GN26640@redhat.com>
References: <20090707192631.GQ11590@us.ibm.com>
	<20090708075601.GJ28046@redhat.com> <4A549990.2060205@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A549990.2060205@us.ibm.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

On Wed, Jul 08, 2009 at 08:05:20AM -0500, Anthony Liguori wrote:
> Gleb Natapov wrote:
> >On Tue, Jul 07, 2009 at 02:26:31PM -0500, Ryan Harper wrote:
> >  
> >>Add a new monitor command (system_reboot) for a soft reboot which uses
> >>system_powerdown to trigger ACPI shutdown in the guest and once shutdown
> >>is complete, trigger a reset instead of exiting qemu.
> >>
> >>Depends on commit a6d6552426dcbf726e5549f08b70c9318d6be14b which enabled
> >>ACPI power button support.
> >>
> >>V2:
> >>    -added reset handler to lower the reboot flag on reset.
> >>    
> >OS is free to ignore ACPI shutdown request and in this case
> >reboot_requested will not be reset. On the next user initiated
> >guest power down qemu will reboot instead of exit.
> >  
> 
> Indeed.  This is what has kept me from applying this but I just can't 
> think of any better solution.
> 
> Any ideas?

Only other option I think of is a pure paravirt shutdown/reboot
handler, ala Xen. That sucks in different ways though, namely
needing a driver in the guest, which is probably worse.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|