From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOXs3-0003KZ-7E
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:11:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOXry-0003Bg-82
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:11:38 -0400
Received: from [199.232.76.173] (port=36091 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOXrx-0003BD-QJ
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:11:33 -0400
Received: from verein.lst.de ([213.95.11.210]:49555)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MOXrx-0008NT-Ap
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:11:33 -0400
Date: Wed, 8 Jul 2009 16:11:31 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak
Message-ID: <20090708141131.GA26000@lst.de>
References: <1247055695-4533-1-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247055695-4533-1-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Jul 08, 2009 at 02:21:35PM +0200, Kevin Wolf wrote:
> qemu-io leaks the request buffer whenever the read or write function isn't
> executed completely down the "normal" code path.

Looks good.  The same problems also happens in the vectored and aio
read/write command, I'll cook up a patch to fix those.