From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOunu-0005DO-Rl for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:40:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOunq-00056h-0c for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:40:54 -0400 Received: from [199.232.76.173] (port=50448 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOunp-00056L-Q0 for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:40:49 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48663) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOunp-00038R-6j for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:40:49 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n69Eelab016118 for ; Thu, 9 Jul 2009 10:40:47 -0400 Date: Thu, 9 Jul 2009 17:40:04 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility. Message-ID: <20090709144004.GB26895@redhat.com> References: <1247144553-8951-1-git-send-email-kraxel@redhat.com> <1247144553-8951-6-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1247144553-8951-6-git-send-email-kraxel@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Jul 09, 2009 at 03:02:33PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > --- > hw/pc.c | 4 ++++ > hw/virtio-pci.c | 13 ++++++++++++- > 2 files changed, 16 insertions(+), 1 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index 0b7c24b..ecb618d 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -1471,6 +1471,10 @@ static QEMUMachine pc_machine_v0_10 = { > .driver = "virtio-console-pci", > .property = "class", > .value = "0x0380", /* PCI_CLASS_DISPLAY_OTHER */ > + },{ > + .driver = "virtio-net-pci", > + .property = "msi", > + .value = "0", > }, > { /* end of list */ } > }, The number of vectors is part of hardware config so it's not a good idea to use a binary property here. Since <= vectors is not a legal msi configuration, it's enough to implement a "vectors" property instead: virtio already interprets zero vectors as no msi. This also matches command line/monitor syntax, which is a good thing. Most virtio-net changes become then unnecessary. -- MST