From: Christoph Hellwig <hch@lst.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-io: small cleanups for the aio code
Date: Fri, 10 Jul 2009 03:37:50 +0200 [thread overview]
Message-ID: <20090710013749.GA18702@lst.de> (raw)
In-Reply-To: <4A564CF3.2040005@codemonkey.ws>
On Thu, Jul 09, 2009 at 03:02:59PM -0500, Anthony Liguori wrote:
> >- if (memcmp(ctx->buf, cmp_buf, total)) {
> >+ memset(cmp_buf, ctx->pattern, ctx->qiov.size);
> >+ if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) {
> > printf("Pattern verification failed at offset %lld, "
> > "%d bytes\n",
> >- (long long) ctx->offset, total);
> >+ (long long) ctx->offset, ctx->qiov.size);
> >
>
> This breaks the build because ctx->qiov.size is a size_t and your format
> parameter is a %d.
Work fine on 32 bit x86 :) But yeah, the correct format that works on
all platforms would be %zd.
next prev parent reply other threads:[~2009-07-10 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 11:20 [Qemu-devel] [PATCH 1/2] qemu-io: small cleanups for the aio code Christoph Hellwig
2009-07-09 20:02 ` Anthony Liguori
2009-07-10 1:37 ` Christoph Hellwig [this message]
2009-07-10 10:20 ` malc
2009-07-10 10:47 ` Christoph Hellwig
2009-07-10 13:04 ` Jamie Lokier
2009-07-10 15:25 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710013749.GA18702@lst.de \
--to=hch@lst.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).