From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPBMI-0006uz-60 for qemu-devel@nongnu.org; Fri, 10 Jul 2009 04:21:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPBMD-0006qO-AB for qemu-devel@nongnu.org; Fri, 10 Jul 2009 04:21:29 -0400 Received: from [199.232.76.173] (port=48283 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPBMC-0006qB-SR for qemu-devel@nongnu.org; Fri, 10 Jul 2009 04:21:25 -0400 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:58206) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MPBMC-0002VO-GD for qemu-devel@nongnu.org; Fri, 10 Jul 2009 04:21:24 -0400 Date: Fri, 10 Jul 2009 10:21:21 +0200 From: Samuel Thibault Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int. Message-ID: <20090710082121.GB5471@const.bordeaux.inria.fr> References: <1246530731-14597-1-git-send-email-yamahata@valinux.co.jp> <1246530731-14597-7-git-send-email-yamahata@valinux.co.jp> <4A564003.5080707@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4A564003.5080707@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Isaku Yamahata , qemu-devel@nongnu.org Anthony Liguori, le Thu 09 Jul 2009 14:07:47 -0500, a écrit : > Isaku Yamahata wrote: > >use uint32_t for ioport port and value instead of int. > > > > Why? In theory int could be only signed 16bit, so at least unsigned int could be needed for the port. uint16_t should be fine. For value, as said uint8/16/32 should probably be better. Samuel