From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPD7E-0002Sn-Pg
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:14:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPD79-0002Ni-Mb
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:14:03 -0400
Received: from [199.232.76.173] (port=42971 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPD79-0002NA-Cq
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:13:59 -0400
Received: from mx20.gnu.org ([199.232.41.8]:13522)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MPD79-0002FU-50
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:13:59 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MPD78-00028T-28
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:13:58 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: add driver class support.
Date: Fri, 10 Jul 2009 11:13:54 +0100
References: <1247144544-8885-1-git-send-email-kraxel@redhat.com>
	<200907101046.22016.paul@codesourcery.com>
	<4A571102.4070503@redhat.com>
In-Reply-To: <4A571102.4070503@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907101113.55407.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Friday 10 July 2009, Gerd Hoffmann wrote:
> On 07/10/09 11:46, Paul Brook wrote:
> >>> But we also
> >>> have to consider the case where a single device exposes multiple types
> >>> of capabilities.
> >>
> >> I think we already agreed to move to a bitmap model to handle that.
> >
> > I still think this is best done via properties, rather than as a separate
> > feature.
>
> Properties really don't fit here IMO.  Property values belong to a
> device *instance*, not to a device *driver*.  If you stick two e1000
> network cards into your virtual machine both instances will have
> different pci bus and mac addresses.  They wouldn't have different
> device capabilities though.

No, but the presence of a mac address (or network backend) property tells you 
that it's a network card.

Paul