From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPKrg-0001VK-F5
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:30:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPKrc-0001T3-TQ
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:30:32 -0400
Received: from [199.232.76.173] (port=46047 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPKrc-0001Sx-Pq
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:30:28 -0400
Received: from verein.lst.de ([213.95.11.210]:43490)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MPKrc-00015u-6L
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:30:28 -0400
Date: Fri, 10 Jul 2009 20:30:19 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg
Message-ID: <20090710183019.GB8725@lst.de>
References: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Huang Ying <ying.huang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Tue, Jun 23, 2009 at 10:05:14AM +0800, Huang Ying wrote:
> - MCE features are initialized when VCPU is intialized according to CPUID.
> - A monitor command "mce" is added to inject a MCE.
> - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MCE.

This patch (now in the qemu tree) breaks compilation for me on i386:

/home/hch/work/qemu/target-i386/helper.c: In function
'cpu_inject_x86_mce':
/home/hch/work/qemu/target-i386/helper.c:1510: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1517: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1525: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1527: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1536: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1537: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1543: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1545: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1546: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1551: error: left shift count >= width of type