From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPJwf-00089P-GQ
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:31:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPJwa-00081d-MF
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:31:36 -0400
Received: from [199.232.76.173] (port=55280 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPJwa-00081F-Dx
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:31:32 -0400
Received: from mx20.gnu.org ([199.232.41.8]:37900)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MPJwa-00076D-4P
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:31:32 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MPJwZ-0004qe-Ab
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:31:31 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 10/13] qdev: add user-specified identifier to
	devices.
Date: Fri, 10 Jul 2009 18:31:28 +0100
References: <1247225179-5495-1-git-send-email-kraxel@redhat.com>
	<1247225179-5495-11-git-send-email-kraxel@redhat.com>
In-Reply-To: <1247225179-5495-11-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907101831.28688.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

On Friday 10 July 2009, Gerd Hoffmann wrote:
>  struct DeviceState {
> +    char id[32];

Fixed size buffers are almost always wrong. Why 31 characters?

Paul