From: Stuart Brady <sdbrady@ntlworld.com>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo
Date: Sat, 11 Jul 2009 21:43:56 +0100 [thread overview]
Message-ID: <20090711204356.GA6219@miranda.arrow> (raw)
In-Reply-To: <b2fa41d60907111122p24d7e2a4vab24e15054205d6f@mail.gmail.com>
On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
> It is clear that intention is to byte-swap value to be written, not
> the target address.
@@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
case 0x89: // Secondary LE
switch(size) {
case 2:
- addr = bswap16(addr);
+ addr = bswap16(val);
^^^^
Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
64-bit cases)? Also needs a 'signed-off-by:'...
Cheers,
--
Stuart Brady
next prev parent reply other threads:[~2009-07-11 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 18:22 [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo Igor Kovalenko
2009-07-11 20:43 ` Stuart Brady [this message]
2009-07-11 20:57 ` Igor Kovalenko
2009-07-12 7:53 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090711204356.GA6219@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=igor.v.kovalenko@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).