From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPjQW-0004Yt-By
	for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:44:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPjQR-0004X9-BF
	for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:44:07 -0400
Received: from [199.232.76.173] (port=36018 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPjQR-0004X6-8X
	for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:44:03 -0400
Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]:34446)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MPjQQ-00077T-Pk
	for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:44:03 -0400
Date: Sat, 11 Jul 2009 21:43:56 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian
	case typo
Message-ID: <20090711204356.GA6219@miranda.arrow>
References: <b2fa41d60907111122p24d7e2a4vab24e15054205d6f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b2fa41d60907111122p24d7e2a4vab24e15054205d6f@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org

On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
> It is clear that intention is to byte-swap value to be written, not
> the target address.

@@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            addr = bswap16(val);
             ^^^^
Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
64-bit cases)?  Also needs a 'signed-off-by:'...

Cheers,
-- 
Stuart Brady