From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPxzR-0008V8-NC for qemu-devel@nongnu.org; Sun, 12 Jul 2009 08:17:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPxzM-0008Tw-Md for qemu-devel@nongnu.org; Sun, 12 Jul 2009 08:17:08 -0400 Received: from [199.232.76.173] (port=33013 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPxzM-0008Tq-GD for qemu-devel@nongnu.org; Sun, 12 Jul 2009 08:17:04 -0400 Received: from mx20.gnu.org ([199.232.41.8]:36023) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPxzM-0001xY-6c for qemu-devel@nongnu.org; Sun, 12 Jul 2009 08:17:04 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MPxzL-0002Kc-4A for qemu-devel@nongnu.org; Sun, 12 Jul 2009 08:17:03 -0400 From: Paul Brook Date: Sun, 12 Jul 2009 13:16:57 +0100 References: <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com> In-Reply-To: <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907121316.58408.paul@codesourcery.com> Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org > +static void ecc_register_devices(void) > +{ > + sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1); > +} I suggest using a name that is a little less generic than "ecc". The device namespace is shared between all machines, and I'm pretty sure there are other ecc controllers out there. What does OpenFirmware call this device? Paul