* [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev
[not found] <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com>
@ 2009-07-12 12:16 ` Paul Brook
2009-07-12 18:29 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Paul Brook @ 2009-07-12 12:16 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
> +static void ecc_register_devices(void)
> +{
> + sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1);
> +}
I suggest using a name that is a little less generic than "ecc". The device
namespace is shared between all machines, and I'm pretty sure there are other
ecc controllers out there. What does OpenFirmware call this device?
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev
2009-07-12 12:16 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev Paul Brook
@ 2009-07-12 18:29 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2009-07-12 18:29 UTC (permalink / raw)
To: Paul Brook; +Cc: qemu-devel
On 7/12/09, Paul Brook <paul@codesourcery.com> wrote:
> > +static void ecc_register_devices(void)
> > +{
> > + sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1);
> > +}
>
> I suggest using a name that is a little less generic than "ecc". The device
> namespace is shared between all machines, and I'm pretty sure there are other
> ecc controllers out there. What does OpenFirmware call this device?
It's "eccmemctl". Actually this was one of the things I was going to
check before committing but forgot to. I'll rename it.
OpenFirmware names are not always consistent, for example escc (Zilog
device name) is escc on PPC, but it's zs (Zilog serial) on Sparc32.
Likewise ata (PPC) vs. ide on Sparc64. I think it'll still be useful
to aim for OF compatible names if possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-12 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com>
2009-07-12 12:16 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev Paul Brook
2009-07-12 18:29 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).