From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQ8rf-0008JG-UE
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 19:53:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQ8rd-0008Ir-3k
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 19:53:51 -0400
Received: from [199.232.76.173] (port=56871 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQ8rc-0008Io-Tw
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 19:53:49 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58050)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1MQ8rc-0006dH-GF
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 19:53:48 -0400
Date: Mon, 13 Jul 2009 01:53:38 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [patch 1/2] ppc tcg: fix wrong bit/mask of wrteei
	(resend)
Message-ID: <20090712235338.GD28418@volta.aurel32.net>
References: <3cdfa5bc0907030356j63ad154cx895b4373dd6fcaa1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <3cdfa5bc0907030356j63ad154cx895b4373dd6fcaa1@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Baojun Wang <wangbj@gmail.com>
Cc: qemu-devel@nongnu.org

On Fri, Jul 03, 2009 at 06:56:57PM +0800, Baojun Wang wrote:
> Signed-off-by: Baojun Wang <wangbj@gmail.com>

Thanks, applied.

> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index a14d197..446ad9e 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -5935,7 +5935,7 @@ static void gen_wrteei(DisasContext *ctx)
>          gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC);
>          return;
>      }
> -    if (ctx->opcode & 0x00010000) {
> +    if (ctx->opcode & 0x00008000) {
>          tcg_gen_ori_tl(cpu_msr, cpu_msr, (1 << MSR_EE));
>          /* Stop translation to have a chance to raise an exception */
>          gen_stop_exception(ctx);
> @@ -8150,7 +8150,7 @@ GEN_HANDLER2(tlbre_440, "tlbre", 0x1F, 0x12,
> 0x1D, 0x00000001, PPC_BOOKE),
>  GEN_HANDLER2(tlbsx_440, "tlbsx", 0x1F, 0x12, 0x1C, 0x00000000, PPC_BOOKE),
>  GEN_HANDLER2(tlbwe_440, "tlbwe", 0x1F, 0x12, 0x1E, 0x00000001, PPC_BOOKE),
>  GEN_HANDLER(wrtee, 0x1F, 0x03, 0x04, 0x000FFC01, PPC_WRTEE),
> -GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000EFC01, PPC_WRTEE),
> +GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000E7C01, PPC_WRTEE),
>  GEN_HANDLER(dlmzb, 0x1F, 0x0E, 0x02, 0x00000000, PPC_440_SPEC),
>  GEN_HANDLER(mbar, 0x1F, 0x16, 0x1a, 0x001FF801, PPC_BOOKE),
>  GEN_HANDLER(msync, 0x1F, 0x16, 0x12, 0x03FFF801, PPC_BOOKE),
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net