* [Qemu-devel] [patch 1/2] ppc tcg: fix wrong bit/mask of wrteei (resend)
@ 2009-07-03 10:56 Baojun Wang
2009-07-12 23:53 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Baojun Wang @ 2009-07-03 10:56 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Baojun Wang <wangbj@gmail.com>
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index a14d197..446ad9e 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -5935,7 +5935,7 @@ static void gen_wrteei(DisasContext *ctx)
gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC);
return;
}
- if (ctx->opcode & 0x00010000) {
+ if (ctx->opcode & 0x00008000) {
tcg_gen_ori_tl(cpu_msr, cpu_msr, (1 << MSR_EE));
/* Stop translation to have a chance to raise an exception */
gen_stop_exception(ctx);
@@ -8150,7 +8150,7 @@ GEN_HANDLER2(tlbre_440, "tlbre", 0x1F, 0x12,
0x1D, 0x00000001, PPC_BOOKE),
GEN_HANDLER2(tlbsx_440, "tlbsx", 0x1F, 0x12, 0x1C, 0x00000000, PPC_BOOKE),
GEN_HANDLER2(tlbwe_440, "tlbwe", 0x1F, 0x12, 0x1E, 0x00000001, PPC_BOOKE),
GEN_HANDLER(wrtee, 0x1F, 0x03, 0x04, 0x000FFC01, PPC_WRTEE),
-GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000EFC01, PPC_WRTEE),
+GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000E7C01, PPC_WRTEE),
GEN_HANDLER(dlmzb, 0x1F, 0x0E, 0x02, 0x00000000, PPC_440_SPEC),
GEN_HANDLER(mbar, 0x1F, 0x16, 0x1a, 0x001FF801, PPC_BOOKE),
GEN_HANDLER(msync, 0x1F, 0x16, 0x12, 0x03FFF801, PPC_BOOKE),
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [patch 1/2] ppc tcg: fix wrong bit/mask of wrteei (resend)
2009-07-03 10:56 [Qemu-devel] [patch 1/2] ppc tcg: fix wrong bit/mask of wrteei (resend) Baojun Wang
@ 2009-07-12 23:53 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2009-07-12 23:53 UTC (permalink / raw)
To: Baojun Wang; +Cc: qemu-devel
On Fri, Jul 03, 2009 at 06:56:57PM +0800, Baojun Wang wrote:
> Signed-off-by: Baojun Wang <wangbj@gmail.com>
Thanks, applied.
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index a14d197..446ad9e 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -5935,7 +5935,7 @@ static void gen_wrteei(DisasContext *ctx)
> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC);
> return;
> }
> - if (ctx->opcode & 0x00010000) {
> + if (ctx->opcode & 0x00008000) {
> tcg_gen_ori_tl(cpu_msr, cpu_msr, (1 << MSR_EE));
> /* Stop translation to have a chance to raise an exception */
> gen_stop_exception(ctx);
> @@ -8150,7 +8150,7 @@ GEN_HANDLER2(tlbre_440, "tlbre", 0x1F, 0x12,
> 0x1D, 0x00000001, PPC_BOOKE),
> GEN_HANDLER2(tlbsx_440, "tlbsx", 0x1F, 0x12, 0x1C, 0x00000000, PPC_BOOKE),
> GEN_HANDLER2(tlbwe_440, "tlbwe", 0x1F, 0x12, 0x1E, 0x00000001, PPC_BOOKE),
> GEN_HANDLER(wrtee, 0x1F, 0x03, 0x04, 0x000FFC01, PPC_WRTEE),
> -GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000EFC01, PPC_WRTEE),
> +GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000E7C01, PPC_WRTEE),
> GEN_HANDLER(dlmzb, 0x1F, 0x0E, 0x02, 0x00000000, PPC_440_SPEC),
> GEN_HANDLER(mbar, 0x1F, 0x16, 0x1a, 0x001FF801, PPC_BOOKE),
> GEN_HANDLER(msync, 0x1F, 0x16, 0x12, 0x03FFF801, PPC_BOOKE),
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-12 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-03 10:56 [Qemu-devel] [patch 1/2] ppc tcg: fix wrong bit/mask of wrteei (resend) Baojun Wang
2009-07-12 23:53 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).