From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove dead i386 assembly code from softmmu_header.h
Date: Mon, 13 Jul 2009 01:08:41 +0100 [thread overview]
Message-ID: <20090713000840.GA8782@miranda.arrow> (raw)
In-Reply-To: <20090712190940.GA8452@miranda.arrow>
On Sun, Jul 12, 2009 at 08:09:40PM +0100, Stuart Brady wrote:
> This patch removes dead i386 assembly code from softmmu_header.h.
>
> The code is conditional on ASM_SOFTMMU, which is never defined.
> Optimisation for the fast path is already handled by tcg_out_qemu_ld()
> and tcg_out_qemu_st(), so there seems to be little need for this code.
To answer a question that was put to me off-list, the code in question
is virtually identical to that generated by the i386 tcg_out_qemu_ld()
and tcg_out_qemu_st() functions[1], with the exception that the TCG
functions also handle loads/stores that are 64-bit and/or big-endian.
Cheers,
--
Stuart Brady
[1] Assuming that tcg_out_qemu_ld() and tcg_out_qemu_st() are commented
correctly -- I didn't actually check the generated machine code, but
I've no particular reason to distrust it.
prev parent reply other threads:[~2009-07-13 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 19:09 [Qemu-devel] [PATCH] Remove dead i386 assembly code from softmmu_header.h Stuart Brady
2009-07-13 0:08 ` Stuart Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713000840.GA8782@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
--cc=stuart.brady@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).