From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQ967-0005F6-W0
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 20:08:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQ962-0005Dl-W8
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 20:08:47 -0400
Received: from [199.232.76.173] (port=34212 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQ962-0005Di-Sp
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 20:08:42 -0400
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:9237)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MQ962-0000Ay-D2
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 20:08:42 -0400
Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090713000838.IYZE6611.mtaout02-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Mon, 13 Jul 2009 01:08:38 +0100
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout01-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090713000838.BXFM13254.aamtaout01-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Mon, 13 Jul 2009 01:08:38 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1MQ961-0002Iw-4o
	for qemu-devel@nongnu.org; Mon, 13 Jul 2009 01:08:41 +0100
Date: Mon, 13 Jul 2009 01:08:41 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] Remove dead i386 assembly code from
	softmmu_header.h
Message-ID: <20090713000840.GA8782@miranda.arrow>
References: <20090712190940.GA8452@miranda.arrow>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090712190940.GA8452@miranda.arrow>
Reply-To: Stuart Brady <stuart.brady@gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Jul 12, 2009 at 08:09:40PM +0100, Stuart Brady wrote:
> This patch removes dead i386 assembly code from softmmu_header.h.
> 
> The code is conditional on ASM_SOFTMMU, which is never defined.
> Optimisation for the fast path is already handled by tcg_out_qemu_ld()
> and tcg_out_qemu_st(), so there seems to be little need for this code.

To answer a question that was put to me off-list, the code in question
is virtually identical to that generated by the i386 tcg_out_qemu_ld()
and tcg_out_qemu_st() functions[1], with the exception that the TCG
functions also handle loads/stores that are 64-bit and/or big-endian.

Cheers,
-- 
Stuart Brady

[1] Assuming that tcg_out_qemu_ld() and tcg_out_qemu_st() are commented
correctly -- I didn't actually check the generated machine code, but
I've no particular reason to distrust it.