From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQpQj-0007jN-T1
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:20:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQpQf-0007fo-CG
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:20:53 -0400
Received: from [199.232.76.173] (port=33400 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQpQf-0007ff-1K
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:20:49 -0400
Received: from verein.lst.de ([213.95.11.210]:42257)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MQpQe-0001ek-JR
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:20:48 -0400
Date: Tue, 14 Jul 2009 23:20:44 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: fix pattern for write test
Message-ID: <20090714212044.GA7580@lst.de>
References: <1247315696-5877-1-git-send-email-weil@mail.berlios.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247315696-5877-1-git-send-email-weil@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Christoph Hellwig <hch@lst.de>, QEMU Developers <qemu-devel@nongnu.org>

On Sat, Jul 11, 2009 at 02:34:56PM +0200, Stefan Weil wrote:
> The write pattern value 0axb is invalid and evaluates to 0,
> so the read check (which uses a correct value of 0xab) will fail.
> 
> This failure will only be detected with a separate patch for
> qemu-io. Without it, qemu-io cannot interpret hex values
> and always uses a pattern value of 0.

Thanks a lot, I've put this patch in.