From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQpUf-0001f0-B8
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:24:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQpUa-0001c8-N3
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:24:56 -0400
Received: from [199.232.76.173] (port=49274 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQpUa-0001br-9S
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:24:52 -0400
Received: from verein.lst.de ([213.95.11.210]:42346)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MQpUZ-0002OS-Q0
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:24:52 -0400
Date: Tue, 14 Jul 2009 23:24:49 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments
Message-ID: <20090714212449.GB7580@lst.de>
References: <1247315696-5877-1-git-send-email-weil@mail.berlios.de>
	<1247315744-5911-1-git-send-email-weil@mail.berlios.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247315744-5911-1-git-send-email-weil@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Christoph Hellwig <hch@lst.de>

On Sat, Jul 11, 2009 at 02:35:44PM +0200, Stefan Weil wrote:
> atoi won't parse sedecimal pattern values (it always returns 0).
> The qemu-iotests use such pattern values, to strtol is needed
> to get correct results.

Indeed.  But now that we're using strtol which can return useful
errors I think we should also handle those errors.  Can you respin
the patch with that error handling added?