From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MR2Dx-0001qt-O5
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 07:00:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MR2Dt-0001iM-Vr
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 07:00:33 -0400
Received: from [199.232.76.173] (port=55960 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MR2Dt-0001i9-JS
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 07:00:29 -0400
Received: from os.inf.tu-dresden.de ([141.76.48.99]:39309)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kauer@os.inf.tu-dresden.de>) id 1MR2Ds-0002sy-VD
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 07:00:29 -0400
Received: from erwin.inf.tu-dresden.de ([141.76.48.80]
	helo=chrom.inf.tu-dresden.de)
	by os.inf.tu-dresden.de with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69)
	id 1MR2Dr-00013z-9v
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 13:00:27 +0200
Received: from kauer by chrom.inf.tu-dresden.de with local (Exim 4.69)
	(envelope-from <kauer@chrom.inf.tu-dresden.de>) id 1MR2Dq-0007pq-H8
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 13:00:26 +0200
Date: Wed, 15 Jul 2009 13:00:26 +0200
From: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
Subject: Re: [Qemu-devel] [PATCH] fix ncurses output
Message-ID: <20090715110026.GA30109@chrom.inf.tu-dresden.de>
References: <20080225174806.GI3136@chrom.inf.tu-dresden.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080225174806.GI3136@chrom.inf.tu-dresden.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This bug is still present. Somebody willing to fix it?


	Bernhard


On Mon, Feb 25, 2008 at 06:48:06PM +0100, Bernhard Kauer wrote:
> The ncurses console uses mvwaddchnstr() to print a line of output
> to a ncurses pad. Unfortunately this routine stops to print further
> chars if a zero-char is seen in the line. This has the effect that
> parts of a line are never redraw.
> 
> The following patch puts spaces instead of the zeros into the line-buffer.
> Please note that this change affects other consoles as well and is
> perhaps undesirable. Comments?
> 
> 
> 	Bernhard Kauer

> Index: console.h
> --- console.h	10 Feb 2008 16:33:13 -0000	1.2
> +++ console.h	25 Feb 2008 17:25:53 -0000
> @@ -104,7 +104,8 @@
>  typedef unsigned long console_ch_t;
>  static inline void console_write_ch(console_ch_t *dest, uint32_t ch)
>  {
> -    cpu_to_le32wu((uint32_t *) dest, ch);
> +  if (!(ch & 0xff))  ch = 0x20;
> +  cpu_to_le32wu((uint32_t *) dest, ch);
>  }
>  
>  typedef void (*vga_hw_update_ptr)(void *);