From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MR3Y4-00074m-I3
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 08:25:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MR3Xz-0006v8-Pn
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 08:25:23 -0400
Received: from [199.232.76.173] (port=54453 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MR3Xz-0006uX-8a
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 08:25:19 -0400
Received: from verein.lst.de ([213.95.11.210]:32789)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MR3Xy-0004Wx-Mk
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 08:25:18 -0400
Date: Wed, 15 Jul 2009 14:25:16 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Implement
	bdrv_load_vmstate/bdrv_save_vmstate
Message-ID: <20090715122516.GA22724@lst.de>
References: <1247652418-9726-1-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247652418-9726-1-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Jul 15, 2009 at 12:06:58PM +0200, Kevin Wolf wrote:
> The load_vmstate and save_vmstate functions are implemented as a
> variation of the normal read/write operation, enabled by the -b option.
> This is the same mechanism as is used to switch from read/write to
> pread/pwrite.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> This depends on Christoph's renaming patch (get/put_buffer =>
> load/save_vmstate) which already is in aliguori-queue.git

It would be really good to get these two in ASAP so that we can start
using this in qemu-iotests.