qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Amit Shah <amit.shah@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Ryan Harper <ryanh@us.ibm.com>, Avi Kivity <avi@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot
Date: Thu, 16 Jul 2009 15:39:59 +0100	[thread overview]
Message-ID: <20090716143959.GC16461@shareable.org> (raw)
In-Reply-To: <20090716085843.GA14243@amit-x200.redhat.com>

Amit Shah wrote:
> On (Wed) Jul 08 2009 [19:02:16], Avi Kivity wrote:
> > On 07/08/2009 06:43 PM, Ryan Harper wrote:
> >>> That suffers from the same problem as a system_reboot command in that
> >>> the guest may never start the shutdown. If that's an acceptable
> >>> limitation, then we might as well implement it directly in QEMU as
> >>> system_reboot so its easily available to everyone. Make 'system_reboot'
> >>> take an optional timeout arg (default to 60 seconds) after which it
> >>> cancels its plans.
> >>>      
> >>
> >> This seems the most reasonable thing to me.  As already mentioned,
> >> system_powerdown already is non-deterministic since the guest could
> >> ignore the ACPI event.
> >>    
> >
> > It could also send the guest to sleep or initiate the self destruct  
> > sequence.  I don't think we should press the power button unless the  
> > user explicitly asked us to.  This means we'll need a guest agent like 
> > Xen.
> 
> This is another use-case for vmchannel (or virtio-serial) where  the user
> exists within qemu.

What happens then the guest is non-responsive because it crashed, or
the agent isn't working, or the guest doesn't support virtio?

Some way to override the guest is needed for all reboot/powerdown options.

"kill -9 $(pidof kvm)" is really unacceptable, but I've had to do it
on several occasions unfortunately.

Ideally, an option to those commands "--force" to ignore the guest and
just do it, and an option like "--timeout-force=5" to behave like
holding down the power button on a real computer.

(It would be nice to be able to change the value of -no-shutdown and
-no-reboot from the monitor, too.)

-- Jamie

  reply	other threads:[~2009-07-16 14:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 19:26 [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot Ryan Harper
2009-07-08  5:06 ` Avi Kivity
2009-07-08 13:07   ` Anthony Liguori
2009-07-08 13:11     ` Avi Kivity
2009-07-08 13:16       ` Anthony Liguori
2009-07-08 13:28         ` Avi Kivity
2009-07-08  7:56 ` Gleb Natapov
2009-07-08 13:05   ` Anthony Liguori
2009-07-08 13:26     ` Daniel P. Berrange
2009-07-08 13:47       ` Anthony Liguori
2009-07-08 13:56         ` Daniel P. Berrange
2009-07-08 13:59           ` Anthony Liguori
2009-07-08 15:43           ` Ryan Harper
2009-07-08 15:49             ` Anthony Liguori
2009-07-08 15:58               ` Ryan Harper
2009-07-08 16:02                 ` Anthony Liguori
2009-07-08 16:02             ` Avi Kivity
2009-07-16  8:58               ` Amit Shah
2009-07-16 14:39                 ` Jamie Lokier [this message]
2009-07-16 14:49                   ` Amit Shah
2009-07-08 13:49     ` Gleb Natapov
2009-07-08 14:04     ` Avi Kivity
2009-07-08 14:10       ` Daniel P. Berrange
2009-07-08 15:16         ` Avi Kivity
2009-07-08 15:47           ` Stefano Stabellini
2009-07-08 15:54             ` Daniel P. Berrange
2009-07-08 15:59               ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716143959.GC16461@shareable.org \
    --to=jamie@shareable.org \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ryanh@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).