From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRU4Z-00036I-6y
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 12:44:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRU4U-00030n-9v
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 12:44:42 -0400
Received: from [199.232.76.173] (port=57715 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRU4T-0002zy-Lx
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 12:44:37 -0400
Received: from verein.lst.de ([213.95.11.210]:36016)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MRU4T-0002oc-Cz
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 12:44:37 -0400
Date: Thu, 16 Jul 2009 18:44:33 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: test I/O after EOF for
	growable files
Message-ID: <20090716164433.GA7832@lst.de>
References: <20090715211335.GA18960@lst.de> <4A5EE0F4.3000108@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A5EE0F4.3000108@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Thu, Jul 16, 2009 at 10:12:36AM +0200, Kevin Wolf wrote:
> Christoph Hellwig schrieb:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Maybe include a test for reads/writes that start before EOF, so the EOF
> is somewhere in the middle of the request?

Yeah, good point.  I've commited the test as-is for now but I'll add
that case soon.

> Looks good to me otherwise (and shows that qemu-io is buggy now that raw
> doesn't have a protocol name any more).

Yeah, see the patch I sent to fix that part.