From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRUZt-0005vL-Oh for qemu-devel@nongnu.org; Thu, 16 Jul 2009 13:17:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRUZp-0005pf-2p for qemu-devel@nongnu.org; Thu, 16 Jul 2009 13:17:05 -0400 Received: from [199.232.76.173] (port=52175 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRUZo-0005pT-Ts for qemu-devel@nongnu.org; Thu, 16 Jul 2009 13:17:00 -0400 Received: from verein.lst.de ([213.95.11.210]:36561) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MRUZo-0008IP-Fg for qemu-devel@nongnu.org; Thu, 16 Jul 2009 13:17:00 -0400 Date: Thu, 16 Jul 2009 19:16:58 +0200 From: Christoph Hellwig Message-ID: <20090716171658.GA9057@lst.de> References: <1247738940-12061-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1247738940-12061-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] Re: [PATCH 0/4] qemu-iotests: Backing file tests List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Jul 16, 2009 at 12:08:56PM +0200, Kevin Wolf wrote: > This series adds some patches for backing files to qemu-iotests. It is meant to > be applied on top of the recently posted patch introducing test 016. Thanks, I've put all the patches in. It would be good if we could get Akkarit ASAP as I really don't want to keep failing tests for the major formats (really just raw and qcow2) around for more than nessecary. I wonder if we'll eventually have to add an xfail mechanism for the other formats as we can't really rely on them being maintained and getting fixed ASAP. These patches also bring two issues up I'll want to eventually fixed: - the use of the $(( )) synatx is a bashism. We'll either need to switch to officially requiring bash and using #!/bin/bash in the first line or switch to use Posix sh synax using let or the expr helper. Given how nice $(( )) is I'd lean towards the former. - We'll probably want to introduce standard $TEST_BACKING_IMG and similar variables aswell as shell functions for creating and dealing with them now that they get more common. Same for the .orig stuff we use when creating compressed images. none of that is really ugent, though.