From: Glauber Costa <glommer@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] introduce on_vcpu
Date: Thu, 16 Jul 2009 18:35:20 -0300 [thread overview]
Message-ID: <20090716213520.GB4019@poweredge.glommer> (raw)
In-Reply-To: <4A5F9AB8.5060206@codemonkey.ws>
On Thu, Jul 16, 2009 at 04:25:12PM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> Yes. Purpose of using curren_env was just to make it look more like qemu-kvm
>> But I do understand that we'll have to change it anyway for this code to
>> have any actual value, so I'm fine with using cpu_single_env.
>>
>
> Yeah, if qemu-kvm is introduce another global current CPUState variable,
> then the qemu-kvm code has to change :-)
>
> Since qemu-kvm keeps a thread id in CPUState, it would make more sense
> to check whether gettid() == env->thread_id, no?
disagree.
gettid involves a syscall. current_env in qemu-kvm is a TLS variable.
probably much cheaper.
next prev parent reply other threads:[~2009-07-16 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 16:47 [Qemu-devel] [PATCH] introduce on_vcpu Glauber Costa
2009-07-16 21:19 ` Anthony Liguori
2009-07-16 21:29 ` Glauber Costa
2009-07-16 21:25 ` Anthony Liguori
2009-07-16 21:35 ` Glauber Costa [this message]
2009-07-16 21:35 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716213520.GB4019@poweredge.glommer \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).