From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRYsy-0007ya-AD
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:53:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRYst-0007qF-EZ
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:53:03 -0400
Received: from [199.232.76.173] (port=59218 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRYst-0007pl-30
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:52:59 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44725)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1MRYss-0004S7-JE
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:52:58 -0400
Date: Thu, 16 Jul 2009 18:59:42 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090716215942.GC4019@poweredge.glommer>
References: <1247779525-16943-1-git-send-email-glommer@redhat.com>
	<4A5F9D32.9060700@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A5F9D32.9060700@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCH v2] introduce on_vcpu
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org

On Thu, Jul 16, 2009 at 04:35:46PM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> on_vcpu is a qemu-kvm function that will make sure that a specific
>> piece of code will run on a requested cpu. We don't need that because
>> we're restricted to -smp 1 right now, but those days are likely to end soon.
>>
>> So for the benefit of having qemu-kvm share more code with us, I'm
>> introducing our own version of on_vcpu(). Right now, we either run
>> a function on the current cpu, or abort the execution, because it would
>> mean something is seriously wrong.
>>
>> As an example code, I "ported" kvm_update_guest_debug to use it,
>> with some slight differences from qemu-kvm.
>>
>> This is probably 0.12 material
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>> CC: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  kvm-all.c |   37 +++++++++++++++++++++++++++++++------
>>  1 files changed, 31 insertions(+), 6 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 61194b8..0c881e8 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -39,6 +39,8 @@
>>      do { } while (0)
>>  #endif
>>
>> +CPUState *current_env;
>> +
>>   
>
> That shouldn't be there anymore...
oops ;-)

>
> -- 
> Regards,
>
> Anthony Liguori
>