From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vmdk: Fix backing file handling
Date: Fri, 17 Jul 2009 12:34:38 +0200 [thread overview]
Message-ID: <20090717103438.GA6729@lst.de> (raw)
In-Reply-To: <1247811641-10235-1-git-send-email-kwolf@redhat.com>
On Fri, Jul 17, 2009 at 08:20:41AM +0200, Kevin Wolf wrote:
> Instead of storing the backing file in its own BlockDriverState, VMDK uses the
> BlockDriverState of the raw image file it opened. This is wrong and breaks
> functions that access the backing file or protocols. This fix replaces all
> occurrences of s->hd->backing_* with bs->backing_*.
>
> This fixes qemu-iotests failure in 020 (Commit changes to backing file).
Wow, that's an interesting one. Looks good to me.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, the vmdk seems to assume the backing_hd always is a vmdk image,
too. I'm not sure if it is a good assumption. While the backing_hd is
found following the parentFileNameHint field in the image there's
nothing preventing a user / admin from having a different kind of image
in that place.
next prev parent reply other threads:[~2009-07-17 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 6:20 [Qemu-devel] [PATCH] vmdk: Fix backing file handling Kevin Wolf
2009-07-17 10:34 ` Christoph Hellwig [this message]
2009-07-17 10:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717103438.GA6729@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).