From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRkm6-0000Mv-LN
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 06:34:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRkm2-0000MP-5R
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 06:34:46 -0400
Received: from [199.232.76.173] (port=35902 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRkm2-0000MM-06
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 06:34:42 -0400
Received: from verein.lst.de ([213.95.11.210]:57396)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MRkm1-0001Fx-7S
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 06:34:41 -0400
Date: Fri, 17 Jul 2009 12:34:38 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] vmdk: Fix backing file handling
Message-ID: <20090717103438.GA6729@lst.de>
References: <1247811641-10235-1-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247811641-10235-1-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Jul 17, 2009 at 08:20:41AM +0200, Kevin Wolf wrote:
> Instead of storing the backing file in its own BlockDriverState, VMDK uses the
> BlockDriverState of the raw image file it opened. This is wrong and breaks
> functions that access the backing file or protocols. This fix replaces all
> occurrences of s->hd->backing_* with bs->backing_*.
> 
> This fixes qemu-iotests failure in 020 (Commit changes to backing file).

Wow, that's an interesting one.  Looks good to me.


Reviewed-by: Christoph Hellwig <hch@lst.de>

Btw, the vmdk seems to assume the backing_hd always is a vmdk image,
too.  I'm not sure if it is a good assumption.  While the backing_hd is
found following the parentFileNameHint field in the image there's
nothing preventing a user / admin from having a different kind of image
in that place.