From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRo27-0002La-51 for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:03:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRo22-0002Hb-UJ for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:03:30 -0400 Received: from [199.232.76.173] (port=48044 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRo22-0002HP-QD for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:03:26 -0400 Received: from [217.9.48.20] (port=37312 helo=donner.amd.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MRo22-0000Bx-48 for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:03:26 -0400 Received: from localhost.amd.com (cegger@localhost.amd.com [127.0.0.1]) by donner.amd.com (8.14.3/8.13.6) with ESMTP id n6HDWnnQ029684 for ; Fri, 17 Jul 2009 15:32:49 +0200 (CEST) From: Christoph Egger Date: Fri, 17 Jul 2009 15:32:48 +0200 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_A2HYKKXULN7Mnxr" Message-Id: <200907171532.48807.Christoph.Egger@amd.com> Subject: [Qemu-devel] [PATCH] bsd-users: fix strace List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --Boundary-00=_A2HYKKXULN7Mnxr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi! Attached patch fixes an unlock bug in strace. Catched by gcc due to an use of uninitialized variable. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_A2HYKKXULN7Mnxr Content-Type: text/x-diff; charset="us-ascii"; name="qemu_bsduser_strace.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="qemu_bsduser_strace.diff" diff --git a/bsd-user/strace.c b/bsd-user/strace.c index 0998dc5..d73bbca 100644 --- a/bsd-user/strace.c +++ b/bsd-user/strace.c @@ -36,7 +36,7 @@ print_execve(const struct syscallname *name, unlock_user(s, arg1, 0); for (arg_ptr_addr = arg2; ; arg_ptr_addr += sizeof(abi_ulong)) { - abi_ulong *arg_ptr, arg_addr, s_addr; + abi_ulong *arg_ptr, arg_addr; arg_ptr = lock_user(VERIFY_READ, arg_ptr_addr, sizeof(abi_ulong), 1); if (!arg_ptr) @@ -47,7 +47,7 @@ print_execve(const struct syscallname *name, break; if ((s = lock_user_string(arg_addr))) { gemu_log("\"%s\",", s); - unlock_user(s, s_addr, 0); + unlock_user(s, arg_addr, 0); } } --Boundary-00=_A2HYKKXULN7Mnxr--