From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRotW-0002im-BL
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:58:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRotR-0002X3-1j
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:58:41 -0400
Received: from [199.232.76.173] (port=54795 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRotQ-0002WY-E0
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:58:36 -0400
Received: from mx20.gnu.org ([199.232.41.8]:9593)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MRotQ-0004xi-4B
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:58:36 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MRotO-0001IL-W9
	for qemu-devel@nongnu.org; Fri, 17 Jul 2009 10:58:35 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT e813376] Sparc32: fix fdc
	io_base
Date: Fri, 17 Jul 2009 15:58:31 +0100
References: <200907171104.n6HB4EDY011438@d01av04.pok.ibm.com>
	<4A60899E.6020108@codemonkey.ws>
In-Reply-To: <4A60899E.6020108@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907171558.32607.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> >      .qdev.props = (Property[]) {
> >          {
> >              .name = "io_base",
> > -            .info = &qdev_prop_uint32,
> > +            .info = &qdev_prop_taddr,
>
> fdc probably shouldn't use target_phys_addr_t and instead should just
> use a uint64_t for io_base.  target_phys is a CPU type, devices
> shouldn't depend on it.

The qdev support for this device is almost completely bogus.  The device code 
should not be dealing with the base address at all. It should be handled by a 
SysBus MMIO region. fdctrl_init should not be calling fdctrl_init_common. 
Instead everything should be done by the qdev init routine (fdctrl_init1).

The mem_mapped property is also fairly suspect. We almost certainly want two 
different devices. On SysBus device a MMIO region, and the other an ISA device 
(using IO ports) - Note that qdev ISA bus support does not exist yet.

Paul