From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSzsc-0003h3-Gi for qemu-devel@nongnu.org; Mon, 20 Jul 2009 16:54:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSzsY-0003gC-O3 for qemu-devel@nongnu.org; Mon, 20 Jul 2009 16:54:38 -0400 Received: from [199.232.76.173] (port=41341 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSzsY-0003g9-Jh for qemu-devel@nongnu.org; Mon, 20 Jul 2009 16:54:34 -0400 Received: from verein.lst.de ([213.95.11.210]:46408) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MSzsY-0007J7-1D for qemu-devel@nongnu.org; Mon, 20 Jul 2009 16:54:34 -0400 Date: Mon, 20 Jul 2009 22:54:31 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] qemu-io: Rework alloc command Message-ID: <20090720205431.GA10205@lst.de> References: <1248101323-10261-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1248101323-10261-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Mon, Jul 20, 2009 at 04:48:43PM +0200, Kevin Wolf wrote: > The alloc command in qemu-io is mostly useless currently. Instead of doing a > single call to bdrv_is_allocated, we must call bdrv_is_allocated in a loop > until we have found out for each requested sector if it is allocated or not > (bdrv_is_allocated returns a number of sectors that are known to be in the same > state as the first one, but it is not required to include all of them) > > This changes the output format of the alloc command so that a change to the > expected output of qemu-iotests 019 is necessary once this is included. Looks good to me. Can you post the corresponding qemu-iotests patch, too?