From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Glauber Costa <glommer@redhat.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT a61d1f6] notify io_thread at the end of rx handling
Date: Wed, 22 Jul 2009 17:54:58 +0100 [thread overview]
Message-ID: <200907221754.59552.paul@codesourcery.com> (raw)
In-Reply-To: <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>
> This is a backport from qemu-kvm. Just instead of using kvm's specific
> notification mechanism, we use qemu_notify_event()
I find it hard to believe this is the right thing to do. Devices shouldn't
care whether we're using an IO thread or not.
If there's something keeping track of which devices have RX buffers available,
then we should be notifying that directly, not relying on polling form some
unspecified event look. Wasn't this the whole point of adding the packet
queueing to the net layer?
Paul
parent reply other threads:[~2009-07-22 16:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907221754.59552.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).