qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] Re: [Qemu-commits] [COMMIT a61d1f6] notify io_thread at the end of rx handling
       [not found] <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>
@ 2009-07-22 16:54 ` Paul Brook
  0 siblings, 0 replies; only message in thread
From: Paul Brook @ 2009-07-22 16:54 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori, Glauber Costa

> This is a backport from qemu-kvm. Just instead of using kvm's specific
> notification mechanism, we use qemu_notify_event()

I find it hard to believe this is the right thing to do. Devices shouldn't 
care whether we're using an IO thread or not.

If there's something keeping track of which devices have RX buffers available, 
then we should be notifying that directly, not relying on polling form some 
unspecified event look. Wasn't this the whole point of adding the packet 
queueing to the net layer?

Paul

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-22 16:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>
2009-07-22 16:54 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT a61d1f6] notify io_thread at the end of rx handling Paul Brook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).