From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTf5x-0007Ck-86
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:55:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTf5s-0007Bl-Ch
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:55:08 -0400
Received: from [199.232.76.173] (port=39205 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTf5s-0007Bb-4p
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:55:04 -0400
Received: from mx20.gnu.org ([199.232.41.8]:44541)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MTf5r-0004n4-Qd
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:55:03 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MTf5q-0004cr-Le
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:55:02 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Wed, 22 Jul 2009 17:54:58 +0100
References: <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>
In-Reply-To: <200907221626.n6MGQGH9022104@d03av02.boulder.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907221754.59552.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT a61d1f6] notify io_thread
	at the end of rx handling
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Glauber Costa <glommer@redhat.com>

> This is a backport from qemu-kvm. Just instead of using kvm's specific
> notification mechanism, we use qemu_notify_event()

I find it hard to believe this is the right thing to do. Devices shouldn't 
care whether we're using an IO thread or not.

If there's something keeping track of which devices have RX buffers available, 
then we should be notifying that directly, not relying on polling form some 
unspecified event look. Wasn't this the whole point of adding the packet 
queueing to the net layer?

Paul