From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MU1cO-0006cT-Fw for qemu-devel@nongnu.org; Thu, 23 Jul 2009 12:58:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MU1cK-0006cD-Tu for qemu-devel@nongnu.org; Thu, 23 Jul 2009 12:58:08 -0400 Received: from [199.232.76.173] (port=60044 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU1cK-0006cA-On for qemu-devel@nongnu.org; Thu, 23 Jul 2009 12:58:04 -0400 Received: from mx20.gnu.org ([199.232.41.8]:56171) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MU1cK-0005ae-C8 for qemu-devel@nongnu.org; Thu, 23 Jul 2009 12:58:04 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MU1cI-0000g8-V6 for qemu-devel@nongnu.org; Thu, 23 Jul 2009 12:58:03 -0400 Date: Thu, 23 Jul 2009 09:58:01 -0700 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH] configure: fix breakage of --extra-{cflags, ldflags} Message-ID: <20090723165801.GK32566@codesourcery.com> References: <1248349241-26029-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1248349241-26029-1-git-send-email-froydnj@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jul 23, 2009 at 04:40:41AM -0700, Nathan Froyd wrote: > Commit e3fc14c3a1a77a1cda669a3e16f1f6b82577e4ec broke the use of > --extra-{cflags,ldflags} in the case where those flags were necessary > for bits of configure to succeed. For instance, if you did: > > configure [...] --extra-cflags=-I/path/to/zlib/headers \ > --extra-ldflags=-L/path/to/zlib/libraries > > prior to the above commit, the paths would go into CFLAGS and LDFLAGS > for use by the rest of the configure tests. I spoke too soon; it turns out that the use of CFLAGS in the zlib configure test is a local patch we have to QEMU. So this is not an issue for upstream QEMU at the moment. It does raise the question of how configure is supposed to find things in non-standard locations, but since none of the other configure tests seem to care about non-standard compilation scenarios (e.g. using --extra-* to specify the location of the SASL libraries won't work)...this is probably not worth addressing unless people feel it's worthwhile for the sake of Truth and Beauty. Sorry about the noise. -Nathan