From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MUEM1-0001F4-6U
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 02:34:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MUELw-0001Bb-61
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 02:34:04 -0400
Received: from [199.232.76.173] (port=37883 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MUELv-0001B0-Tp
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 02:33:59 -0400
Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:36014
	helo=TX2EHSOBE008.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1MUELt-0003ox-Jh
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 02:33:59 -0400
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [PATCH] Check availability of uuid header / lib
Date: Fri, 24 Jul 2009 08:32:33 +0200
References: <4A6888AC.3050509@mail.berlios.de>
	<1248380874-7298-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1248380874-7298-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200907240832.33998.Christoph.Egger@amd.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thursday 23 July 2009 22:27:54 Stefan Weil wrote:
> The Universally Unique Identifier library will be used
> for the new vdi block driver and maybe other parts of QEMU.

This is very Linux specific.
On NetBSD, the header is in <sys/uuid.h> and part of libc.
The API implements DCE 1.1 RPC specification which is
very different from Linux uuid.

Christoph


>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  Makefile        |    1 +
>  Makefile.target |    2 ++
>  configure       |   21 +++++++++++++++++++++
>  3 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index dc95869..d8fa730 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -29,6 +29,7 @@ else
>  DOCS=
>  endif
>
> +LIBS+=$(UUID_LIBS)
>  LIBS+=$(PTHREADLIBS)
>  LIBS+=$(CLOCKLIBS)
>
> diff --git a/Makefile.target b/Makefile.target
> index f9cd42a..4a01e96 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -469,6 +469,8 @@ ifdef CONFIG_BLUEZ
>  LIBS += $(CONFIG_BLUEZ_LIBS)
>  endif
>
> +LIBS += $(UUID_LIBS)
> +
>  # xen backend driver support
>  obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>  ifeq ($(CONFIG_XEN), y)
> diff --git a/configure b/configure
> index 39bed79..28a9c48 100755
> --- a/configure
> +++ b/configure
> @@ -995,6 +995,22 @@ if $cc $ARCH_CFLAGS -o $TMPE $TMPC > /dev/null 2>
> /dev/null ; then fi
>
>  ##########################################
> +# uuid_generate() probe, used for vdi block driver
> +uuid="no"
> +cat > $TMPC << EOF
> +#include <uuid/uuid.h>
> +int main(void)
> +{
> +    uuid_t my_uuid;
> +    uuid_generate(my_uuid);
> +    return 0;
> +}
> +EOF
> +if $cc $ARCH_CFLAGS -o $TMPE $TMPC -luuid >/dev/null 2>&1; then
> +   uuid="yes"
> +fi
> +
> +##########################################
>  # vde libraries probe
>  if test "$vde" = "yes" ; then
>    cat > $TMPC << EOF
> @@ -1473,6 +1489,7 @@ echo "Install blobs     $blobs"
>  echo -e "KVM support       $kvm"
>  echo "fdt support       $fdt"
>  echo "preadv support    $preadv"
> +echo "uuid support      $uuid"
>
>  if test $sdl_too_old = "yes"; then
>  echo "-> Your SDL version is too old - please upgrade to have SDL support"
> @@ -1655,6 +1672,10 @@ fi
>  if test "$fnmatch" = "yes" ; then
>    echo "#define HAVE_FNMATCH_H 1" >> $config_host_h
>  fi
> +if test "$uuid" = "yes" ; then
> +  echo "#define HAVE_UUID_H 1" >> $config_host_h
> +  echo "UUID_LIBS=-luuid" >> $config_host_mak
> +fi
>  qemu_version=`head $source_path/VERSION`
>  echo "VERSION=$qemu_version" >>$config_host_mak
>  echo "#define QEMU_VERSION \"$qemu_version\"" >> $config_host_h



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632