[Qemu-devel] Re: kvm: savevm is broken for me

[Luiz Capitulino <lcapitulino@redhat.com>]

On Fri, 24 Jul 2009 00:06:13 +0200
Alexander Graf <agraf@suse.de> wrote:

> On 23.07.2009, at 23:58, Luiz Capitulino wrote:
> 
> >
> > Hi there,
> >
> > If I try to 'savevm' with latest Anthony's tree (HEAD
> > 6f725c139ae975646c44ace77bf796318a5783da) QEMU will hang and I know
> > it's not saving anything because vmstat shows no disk activity (which
> > is the opposite behavior of when 'savevm' works).
> >
> > According to 'git bisect' the week's winner is:
> >
> > """
> > commit bd8367761236cd5c435598aeb2f1b8240c09b059
> > Author: Alexander Graf <agraf@suse.de>
> > Date:   Fri Jul 17 13:51:48 2009 +0200
> >
> >    Fake dirty loggin when it's not there
> > """
> >
> > Indeed, reverting this makes 'savevm' work for me.
> 
> 
> Yikes. I have no idea why, but just revert the patch :-). I don't  
> really need it anymore since we now have dirty logging in PPC.
> 
> Maybe it's the if (is dirty logging really enabled?) in the beginning?  

 Yes, it's the if. I have removed it and savevm works.

 Can you submit the fix please?