From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MULE4-0007me-6N
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 09:54:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MULDz-0007ke-IB
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 09:54:19 -0400
Received: from [199.232.76.173] (port=48380 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MULDz-0007kG-0e
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 09:54:15 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45605)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MULDw-0008BE-TS
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 09:54:13 -0400
Date: Fri, 24 Jul 2009 10:54:02 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20090724105402.1ea81ad5@doriath>
In-Reply-To: <BEA72293-318B-41C5-8E4F-0029A38FB52E@suse.de>
References: <20090723185844.474f7c62@doriath>
	<BEA72293-318B-41C5-8E4F-0029A38FB52E@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: kvm: savevm is broken for me
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, 24 Jul 2009 00:06:13 +0200
Alexander Graf <agraf@suse.de> wrote:

> On 23.07.2009, at 23:58, Luiz Capitulino wrote:
> 
> >
> > Hi there,
> >
> > If I try to 'savevm' with latest Anthony's tree (HEAD
> > 6f725c139ae975646c44ace77bf796318a5783da) QEMU will hang and I know
> > it's not saving anything because vmstat shows no disk activity (which
> > is the opposite behavior of when 'savevm' works).
> >
> > According to 'git bisect' the week's winner is:
> >
> > """
> > commit bd8367761236cd5c435598aeb2f1b8240c09b059
> > Author: Alexander Graf <agraf@suse.de>
> > Date:   Fri Jul 17 13:51:48 2009 +0200
> >
> >    Fake dirty loggin when it's not there
> > """
> >
> > Indeed, reverting this makes 'savevm' work for me.
> 
> 
> Yikes. I have no idea why, but just revert the patch :-). I don't  
> really need it anymore since we now have dirty logging in PPC.
> 
> Maybe it's the if (is dirty logging really enabled?) in the beginning?  

 Yes, it's the if. I have removed it and savevm works.

 Can you submit the fix please?