From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MURf3-00064P-UJ
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 16:46:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MURez-000626-Bb
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 16:46:37 -0400
Received: from [199.232.76.173] (port=55519 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MURez-00061u-41
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 16:46:33 -0400
Received: from mx20.gnu.org ([199.232.41.8]:18062)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <froydnj@codesourcery.com>)
	id 1MURey-0002t6-NU
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 16:46:32 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1MURew-00050D-J9
	for qemu-devel@nongnu.org; Fri, 24 Jul 2009 16:46:30 -0400
Date: Fri, 24 Jul 2009 13:46:28 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to
	CONFIG_MACHINE_BSWAP_H
Message-ID: <20090724204628.GU32566@codesourcery.com>
References: <cover.1248459711.git.quintela@redhat.com>
	<22a7a2be00a22a4ab3bbb4fdc634ab7aaacd8d6e.1248459711.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <22a7a2be00a22a4ab3bbb4fdc634ab7aaacd8d6e.1248459711.git.quintela@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote:
> @@ -176,7 +176,7 @@ VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>  CPPFLAGS+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>
>  ifeq ($(ARCH),i386)
> -ifdef TARGET_GPROF
> +ifdef CONFIG_GPROF
>  USE_I386_LD=y
>  endif
>  ifdef CONFIG_STATIC

I don't see anything obviously wrong with the rest of the patch, but
this hunk and others make it look like you forgot to split out a patch
in your patch series.

-Nathan