From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVQ90-0007kp-8s for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:21:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVQ8v-0007jH-SA for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:21:33 -0400 Received: from [199.232.76.173] (port=58784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVQ8v-0007jD-Gy for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:21:29 -0400 Received: from mx20.gnu.org ([199.232.41.8]:31553) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVQ8u-00063q-Ot for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:21:29 -0400 Received: from nan.false.org ([208.75.86.248]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVQ8t-00050e-3O for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:21:27 -0400 Date: Mon, 27 Jul 2009 09:21:23 -0400 From: Daniel Jacobowitz Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(, NULL, _IOLBF, 0) calls for Win32 Message-ID: <20090727132123.GA2428@caradoc.them.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: qemu-devel@nongnu.org On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote: > On Win32 the setvbuf function requires the last parameter to be size between 2 and INT_MAX bytes, so the calls always failed. Since the whole point of the calls is to set line-buffered mode for the file handle and that's not supported on Win32 anyway, conditionally remove them. Should they be unbuffered where _IOLBF is not supported, then? I assume the line buffering was to make them more useful in event of a crash. -- Daniel Jacobowitz CodeSourcery