From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVQT3-0006c4-NX
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:42:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVQSx-0006a5-Qh
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:42:15 -0400
Received: from [199.232.76.173] (port=55766 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVQSw-0006Zm-UR
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:42:11 -0400
Received: from nan.false.org ([208.75.86.248]:41021)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <drow@false.org>) id 1MVQSw-0001Ww-Ke
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:42:10 -0400
Date: Mon, 27 Jul 2009 09:42:08 -0400
From: Daniel Jacobowitz <drow@false.org>
Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL,
	_IOLBF, 0) calls for Win32
Message-ID: <20090727134208.GA3803@caradoc.them.org>
References: <E1MVL9t-0001cm-94@lists.gnu.org>
	<20090727132123.GA2428@caradoc.them.org>
	<5b31733c0907270633xb49d83we1858a6e9ba45d63@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5b31733c0907270633xb49d83we1858a6e9ba45d63@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

On Mon, Jul 27, 2009 at 03:33:08PM +0200, Filip Navara wrote:
> On Mon, Jul 27, 2009 at 3:21 PM, Daniel Jacobowitz<drow@false.org> wrot=
e:
> > On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote:
> >> On Win32 the setvbuf function requires the last parameter to be size=
 between 2 and INT_MAX bytes, so the calls always failed. Since the whole=
 point of the calls is to set line-buffered mode for the file handle and =
that's not supported on Win32 anyway, conditionally remove them.
> >
> > Should they be unbuffered where _IOLBF is not supported, then? =A0I
> > assume the line buffering was to make them more useful in event of a
> > crash.
>=20
> I guess your assumption is correct. I'd be fine with using _IONBF for
> the exec.c part, but setting it for stdout doesn't sound too useful to
> me.

I've found that leaving stdout buffered on Windows is a pain; on Unix
"isatty()" is reliable, but on Windows it breaks down at the
Cygwin/Windows interaction border.  So your simulated programs end up
using block output all the time if you have a mingw32 qemu in a Cygwin
terminal, for instance.

--=20
Daniel Jacobowitz
CodeSourcery