From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVRFZ-0000zD-OP
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:32:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVRFT-0000xr-Bj
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:32:23 -0400
Received: from [199.232.76.173] (port=40397 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVRFT-0000xe-0G
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:32:19 -0400
Received: from nan.false.org ([208.75.86.248]:41951)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <drow@false.org>) id 1MVRFS-00042q-Ne
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 10:32:18 -0400
Date: Mon, 27 Jul 2009 10:32:16 -0400
From: Daniel Jacobowitz <drow@false.org>
Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL,
	_IOLBF, 0) calls for Win32
Message-ID: <20090727143216.GA8161@caradoc.them.org>
References: <E1MVL9t-0001cm-94@lists.gnu.org>
	<20090727132123.GA2428@caradoc.them.org>
	<5b31733c0907270633xb49d83we1858a6e9ba45d63@mail.gmail.com>
	<20090727134208.GA3803@caradoc.them.org>
	<5b31733c0907270725y715098dcl8221e5de2e62995c@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b31733c0907270725y715098dcl8221e5de2e62995c@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

On Mon, Jul 27, 2009 at 04:25:32PM +0200, Filip Navara wrote:
> I use MinGW-built QEMU in regular command line and MSYS sh and I never had a
> single problem with the buffering. I can't speak for Cygwin, but if they
> can't get it right I don't think it's up to QEMU to fix it (heck, checking
> for a console handle is as easy as "(handle & 3) != 0").

It is not a Cygwin problem.  It's a MSVCRT runtime problem.  The
runtime checks isatty to determine the buffering of stdout (this is a
standard C thing to do), and Cygwin terminals do not show up as
consoles.

If the underlying device is really a Windows console, of course,
there's no problem.  But Cygwin SSH ptys, for example, are not
Windows consoles.

-- 
Daniel Jacobowitz
CodeSourcery