From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVUQ5-0008KF-Pa for qemu-devel@nongnu.org; Mon, 27 Jul 2009 13:55:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVUQ0-0008GB-9o for qemu-devel@nongnu.org; Mon, 27 Jul 2009 13:55:28 -0400 Received: from [199.232.76.173] (port=45012 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVUPz-0008Fq-Jk for qemu-devel@nongnu.org; Mon, 27 Jul 2009 13:55:23 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58316) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVUPx-000369-Tb for qemu-devel@nongnu.org; Mon, 27 Jul 2009 13:55:22 -0400 Date: Mon, 27 Jul 2009 15:02:18 -0300 From: Glauber Costa Message-ID: <20090727180218.GF4776@poweredge.glommer> References: <1248466823-12707-1-git-send-email-glommer@redhat.com> <4A6A61D4.1080807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A6A61D4.1080807@redhat.com> Subject: [Qemu-devel] Re: [PATCH] fix broken migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Sat, Jul 25, 2009 at 03:37:24AM +0200, Paolo Bonzini wrote: > On 07/24/2009 10:20 PM, Glauber Costa wrote: >> While fixing migration with -S, commit >> 89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us. > > With this patch a migrated virtual machine will never be restarted. If > you want that, shouldn't you use -S? But if you really wanted a > migrated virtual machine to never be restarted, didn't you have a > problem before my patch as well? > > Note that autostart (the variable) is never read except to choose > whether to do that vm_start; so there can be no collateral effects from > passing -S. > > I don't understand what this patch is trying to achieve (and why). If I pass --incoming to the VM, I don't expect the VM to start. I expect it to wait, because I'll be handling it a migration later. However, it does start, which is clearly wrong. Of course, it does not start if we pass -S in conjunction with --incoming, but this is a totally crazy semantics. An option should not depend on another option to do the right thing. As I said in the changelog, -S is still respected in migration because we're not automatically vm_start()'in anything after migration completes, and also work with a migrated machine that is already running. So what am I missing here?