From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVWYF-0004j6-De
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:12:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVWYA-0004ao-OG
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:12:02 -0400
Received: from [199.232.76.173] (port=51890 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVWYA-0004aW-IB
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:11:58 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54498)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1MVWYA-00005v-5l
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:11:58 -0400
Date: Mon, 27 Jul 2009 17:18:55 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090727201855.GK4776@poweredge.glommer>
References: <1248466823-12707-1-git-send-email-glommer@redhat.com>
	<4A6A61D4.1080807@redhat.com>
	<20090727180218.GF4776@poweredge.glommer>
	<4A6E009F.8010608@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A6E009F.8010608@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] fix broken migration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Mon, Jul 27, 2009 at 09:31:43PM +0200, Paolo Bonzini wrote:
> On 07/27/2009 08:02 PM, Glauber Costa wrote:
>> If I pass --incoming to the VM, I don't expect the VM to start. I expect it
>> to wait, because I'll be handling it a migration later. However, it does start,
>> which is clearly wrong.
>
> I see now, thanks.  I was puzzled by your message, so to speak.
>
> I suppose the best semantics would be to do like
>
>    if (autostart && !incoming)
>        vm_start ()
>
> in vl.c and add
>
>    if (autostart)
>        vm_start ()
>
> in the migration-*.c files.
I don't disagree. This is even more explicit about the meaning of each of
the flags.