From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVWap-0006bu-Ka
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:14:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVWaj-0006ZE-Fc
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:14:41 -0400
Received: from [199.232.76.173] (port=46100 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVWaj-0006Z9-Cj
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:14:37 -0400
Received: from mx2.redhat.com ([66.187.237.31]:53381)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1MVWai-0000VJ-Uq
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 16:14:37 -0400
Date: Mon, 27 Jul 2009 17:21:34 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090727202134.GL4776@poweredge.glommer>
References: <1248719202-24401-1-git-send-email-glommer@redhat.com>
	<4A6DF5AB.6000608@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A6DF5AB.6000608@web.de>
Subject: [Qemu-devel] Re: [PATCH] fix endless look at kvm migration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Mon, Jul 27, 2009 at 08:44:59PM +0200, Jan Kiszka wrote:
> Glauber Costa wrote:
> > If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set
> > on a slot, we will enter an endless loop. Remove the test, since it
> > is not strictly needed anyway
> > 
> > Signed-off-by: Glauber Costa <glommer@redhat.com>
> > CC: Alexander Graf <agraf@suse.de>
> > ---
> >  kvm-all.c |    5 -----
> >  1 files changed, 0 insertions(+), 5 deletions(-)
> > 
> > diff --git a/kvm-all.c b/kvm-all.c
> > index 824bb4c..d3bbd3c 100644
> > --- a/kvm-all.c
> > +++ b/kvm-all.c
> > @@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
> >              break;
> >          }
> >  
> > -        /* We didn't activate dirty logging? Don't care then. */
> > -        if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) {
> > -            continue;
> > -        }
> > -
> >          size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
> >          if (!d.dirty_bitmap) {
> >              d.dirty_bitmap = qemu_malloc(size);
> 
> Please let us revert the whole bd83677.
I'm not opposed either. Avi can surely do that if he prefer.

> 
> Jan
>