From: "Todd T. Fries" <qemu@email.fries.net>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 16/47] O_LARGEFILE is already set in qemu-common.h
Date: Tue, 28 Jul 2009 23:13:28 -0500 [thread overview]
Message-ID: <20090729041328.GA21358@fries.net> (raw)
In-Reply-To: <2363021676118ae5969d34d264f9c68e58731841.1248703754.git.quintela@redhat.com>
Stupid observation here, if you renamed 'HOST_BSD' to 'CONFIG_BSD'
didn't you miss something below?
Penned by Juan Quintela on 20090727 16:12.55, we have:
|
| Signed-off-by: Juan Quintela <quintela@redhat.com>
| ---
| configure | 1 -
| 1 files changed, 0 insertions(+), 1 deletions(-)
|
| diff --git a/configure b/configure
| index 3c5fb6e..be00e28 100755
| --- a/configure
| +++ b/configure
| @@ -1746,7 +1746,6 @@ fi
|
| # XXX: suppress that
| if [ "$bsd" = "yes" ] ; then
| - echo "#define O_LARGEFILE 0" >> $config_host_h
| echo "#define MAP_ANONYMOUS MAP_ANON" >> $config_host_h
| echo "#define HOST_BSD 1" >> $config_host_h
| fi
| --
| 1.6.2.5
|
|
--
Todd Fries .. todd@fries.net
_____________________________________________
| \ 1.636.410.0632 (voice)
| Free Daemon Consulting, LLC \ 1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com \ 1.866.792.3418 (FAX)
| "..in support of free software solutions." \ sip:freedaemon@ekiga.net
| \ sip:4052279094@ekiga.net
\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
37E7 D3EB 74D0 8D66 A68D B866 0326 204E 3F42 004A
http://todd.fries.net/pgp.txt
next prev parent reply other threads:[~2009-07-29 4:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 14:12 [Qemu-devel] [PATCH v3 00/47] More configure/Makefile cleanups Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 01/47] change HOST_SOLARIS to CONFIG_SOLARIS{_VERSION} Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 02/47] Remove SP_CFLAGS and SP_LDFLAGS Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 03/47] target_arch2 is redefined unconditionally later Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 04/47] remove CONFIG_ from VNC_TLS_{LIBS, FLAGS} Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 05/47] use same algorithm for testing and Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 06/47] remove CONFIG_ from VNC_SASL_{LIBS, FLAGS} Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 07/47] remove CONFIG_ from BLUEZ_{LIBS,FLAGS} Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 08/47] make fmod also use FMOD_{LIBS,CFLAGS} Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 09/47] make oss use OSS_LIBS Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 10/47] move printing of config-host.mak variables to end of generation Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 11/47] more specific config.mak can overwrote more general config.mak Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 12/47] Add -static in configure if needed Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 13/47] Rename HAVE_FDT to CONFIG_FDT and define it also in Makefile Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 14/47] Refactor code to remove one #ifdef CONFIG_FDT Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 15/47] fix indententation Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 16/47] O_LARGEFILE is already set in qemu-common.h Juan Quintela
2009-07-29 4:13 ` Todd T. Fries [this message]
2009-07-29 10:51 ` [Qemu-devel] " Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 17/47] rename HOST_BSD to CONFIG_BSD Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 18/47] define MAP_ANONYMOUS if it is not defined in qemu-common.h Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 19/47] rename HAVE_PREADV to CONFIG_PREADV Juan Quintela
2009-07-27 14:12 ` [Qemu-devel] [PATCH 20/47] rename HAVE_IOVEC to CONFIG_IOVEC Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 21/47] rename HAVE_FNMATCH_H to CONFIG_FNMATCH Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 22/47] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 23/47] rename HAVE_GPROF to TARGET_GPROF Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 24/47] rename HAVE_BYTESWAP_H to CONFIG_BYTESWAP_H Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 25/47] rename DEBUG_TCG to CONFIG_DEBUG_TCG Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 26/47] rename DEBUG_EXEC to CONFIG_DEBUG_EXEC Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 27/47] rename WORDS_BIGENDIAN to HOST_WORDS_BIGENDIAN Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 28/47] Add CONFIG_POSIX Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 29/47] Use CONFIG_POSIX to simplify Makefile Juan Quintela
2009-08-01 15:54 ` [Qemu-devel] " Sebastian Herbszt
2009-08-01 16:06 ` Filip Navara
2009-08-03 8:38 ` Juan Quintela
2009-08-03 11:10 ` Filip Navara
2009-08-03 11:36 ` Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 30/47] the else part of this test is obsolete We are testing for sdl = yes inside the else part of the test if sdl = yes Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 31/47] sdl_config value was always sdl-config Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 32/47] Calculate sdl_libs and sdl_flags and use them everywhere Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 33/47] instead of setup sdl_x11 just add -lX11 to sdl_libs Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 34/47] target_softmmu is undefined at that point Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 35/47] remove sdl_static. Just do the right thing if static is yes Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 36/47] indent with 2 spaces sdl tests Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 37/47] Define and use xen libs in a single place Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 38/47] simplify curses library selection Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 39/47] simplify brlapi selection Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 40/47] simplify vde libs selection Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 41/47] simplify fdt " Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 42/47] test if xen is enabled only once Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 43/47] define ENOTSUP the same that the other errors Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 44/47] rename NEEDS_LIBSUNMATH to CONFIG_NEEDS_LIBSUNMATH Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 45/47] rename USE_NPTL to CONFIG_USE_NPTL Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 46/47] Generate config-host.h from config-host.mak Juan Quintela
2009-07-27 14:13 ` [Qemu-devel] [PATCH 47/47] move on_vcpu inside proper #ifdef Juan Quintela
2009-07-27 15:00 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729041328.GA21358@fries.net \
--to=qemu@email.fries.net \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=todd@fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).