From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MW0Yi-0006bK-EX
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 00:14:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MW0Yd-0006au-Nf
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 00:14:31 -0400
Received: from [199.232.76.173] (port=34644 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MW0Yd-0006ar-I0
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 00:14:27 -0400
Received: from pf.freedaemonhosting.com ([66.210.104.252]:39793
	helo=FreeDaemonHosting.com) by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <qemu@email.fries.net>) id 1MW0Yd-00082b-7J
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 00:14:27 -0400
Date: Tue, 28 Jul 2009 23:13:28 -0500
From: "Todd T. Fries" <qemu@email.fries.net>
Subject: Re: [Qemu-devel] [PATCH 16/47] O_LARGEFILE is already set in
	qemu-common.h
Message-ID: <20090729041328.GA21358@fries.net>
References: <cover.1248703754.git.quintela@redhat.com>
	<2363021676118ae5969d34d264f9c68e58731841.1248703754.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2363021676118ae5969d34d264f9c68e58731841.1248703754.git.quintela@redhat.com>
Reply-To: todd@fries.net
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Stupid observation here, if you renamed 'HOST_BSD' to 'CONFIG_BSD'
didn't you miss something below?

Penned by Juan Quintela on 20090727 16:12.55, we have:
| 
| Signed-off-by: Juan Quintela <quintela@redhat.com>
| ---
|  configure |    1 -
|  1 files changed, 0 insertions(+), 1 deletions(-)
| 
| diff --git a/configure b/configure
| index 3c5fb6e..be00e28 100755
| --- a/configure
| +++ b/configure
| @@ -1746,7 +1746,6 @@ fi
| 
|  # XXX: suppress that
|  if [ "$bsd" = "yes" ] ; then
| -  echo "#define O_LARGEFILE 0" >> $config_host_h
|    echo "#define MAP_ANONYMOUS MAP_ANON" >> $config_host_h
|    echo "#define HOST_BSD 1" >> $config_host_h
|  fi
| -- 
| 1.6.2.5
| 
| 

-- 
Todd Fries .. todd@fries.net

 _____________________________________________
|                                             \  1.636.410.0632 (voice)
| Free Daemon Consulting, LLC                 \  1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com             \  1.866.792.3418 (FAX)
| "..in support of free software solutions."  \  sip:freedaemon@ekiga.net
|                                             \  sip:4052279094@ekiga.net
 \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
                                                 
              37E7 D3EB 74D0 8D66 A68D  B866 0326 204E 3F42 004A
                        http://todd.fries.net/pgp.txt