From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MW9DP-0007KI-NS
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:29:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MW9DL-0007Jj-RE
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:29:07 -0400
Received: from [199.232.76.173] (port=36585 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MW9DL-0007Jg-Ld
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:29:03 -0400
Received: from mx20.gnu.org ([199.232.41.8]:3327)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <lcapitulino@redhat.com>)
	id 1MW9DK-0006IF-Pk
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:29:02 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MW9DJ-0004b1-H4
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 09:29:01 -0400
Date: Wed, 29 Jul 2009 10:28:35 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/25] Introduce QEMU dictionary data type
Message-ID: <20090729102835.3e2b546b@doriath>
In-Reply-To: <Pine.LNX.4.64.0907290236570.14932@linmac.oyster.ru>
References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com>
	<1248818713-11261-2-git-send-email-lcapitulino@redhat.com>
	<Pine.LNX.4.64.0907290236570.14932@linmac.oyster.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On Wed, 29 Jul 2009 02:39:03 +0400 (MSD)
malc <av1474@comtv.ru> wrote:

> On Tue, 28 Jul 2009, Luiz Capitulino wrote:
> 
> > A dictionary is a high-level data type used to store a collection of
> > values, where a unique key is associated with one value. Usually, the
> > notation 'key:value' is used to denote this relationship.
> > +
> > +/**
> > + * __qemu_dict_get(): Low-level lookup function
> > + */
> > +static void *__qemu_dict_get(const struct qemu_dict *qdict,
> > +                             const char *key, unsigned int hash)
> 
> Do not violate the standard please.

 What's the problem, the '__' or the indentation?

> [..snip..]
> 
> > @@ -0,0 +1,36 @@
> > +#ifndef __QEMU_DICT_H__
> > +#define __QEMU_DICT_H__
> 
> Ditto.

 Will fix.