From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWAKs-0007pK-8Y
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWAKm-0007nV-Cj
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:52 -0400
Received: from [199.232.76.173] (port=53747 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWAKm-0007nS-6U
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:48 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41449)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MWAKl-0006HA-NJ
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:48 -0400
Date: Wed, 29 Jul 2009 17:40:43 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change
Message-ID: <20090729144043.GE30449@redhat.com>
References: <20090729120719.GN30449@redhat.com>
	<20090729135057.GY30449@redhat.com>
	<5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

On Wed, Jul 29, 2009 at 04:35:52PM +0200, Filip Navara wrote:
> On Wed, Jul 29, 2009 at 3:50 PM, Gleb Natapov<gleb@redhat.com> wrote:
> [snip]
> > @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s)
> >
> > =9A =9A qemu_get_8s(f, &s->sense_key);
> > =9A =9A qemu_get_8s(f, &s->asc);
> > + =9A =9Aqemu_get_8s(f, &s->cdrom_changed);
> > =9A =9A /* XXX: if a transfer is pending, we do not save it yet */
> > =9A}
> >
> > @@ -3219,7 +3223,7 @@ static int pci_ide_load(QEMUFile* f, void *opaque=
, int version_id)
> > =9A =9A PCIIDEState *d =3D opaque;
> > =9A =9A int ret, i;
> >
> > - =9A =9Aif (version_id !=3D 2)
> > + =9A =9Aif (version_id !=3D 3)
> > =9A =9A =9A =9A return -EINVAL;
> > =9A =9A ret =3D pci_device_load(&d->dev, f);
> > =9A =9A if (ret < 0)
>=20
> Why shouldn't we support loading version 2 snapshots? Afterall that's
> why we had the versioning in the first place.
>=20
Does anybody check cross version migration? If no my guess is it is broken.
And I can't even imaging test matrix. Versioning is a good way to
prevent users from doing stupid things.

--
			Gleb.