From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWGcP-0001kt-6P for qemu-devel@nongnu.org; Wed, 29 Jul 2009 17:23:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWGcK-0001kB-KM for qemu-devel@nongnu.org; Wed, 29 Jul 2009 17:23:24 -0400 Received: from [199.232.76.173] (port=46703 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWGcK-0001k8-DH for qemu-devel@nongnu.org; Wed, 29 Jul 2009 17:23:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38914) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWGcJ-00059K-Vl for qemu-devel@nongnu.org; Wed, 29 Jul 2009 17:23:20 -0400 Date: Wed, 29 Jul 2009 18:23:00 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH] kvm: add kvm version to the "info kvm" monitor command Message-ID: <20090729182300.4cdb7be8@doriath> In-Reply-To: <5d6222a80907291348r3c25c802if1b844f3bdae11e3@mail.gmail.com> References: <1248865418-32604-1-git-send-email-bjorn@mork.no> <20090729154837.3f1872f2@doriath> <5d6222a80907291348r3c25c802if1b844f3bdae11e3@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org, =?UTF-8?B?QmrDuHJu?= Mork On Wed, 29 Jul 2009 17:48:13 -0300 Glauber Costa wrote: > On Wed, Jul 29, 2009 at 3:48 PM, Luiz Capitulino = wrote: > > On Wed, 29 Jul 2009 13:03:38 +0200 > > Bj=C3=B8rn Mork wrote: > > > >> There isn't a one-to-one mapping between the KVM version and > >> the QEMU version output from "info version". =C2=A0Complete the > >> picture by adding the KVM version to the existing "info kvm" > >> monitor command. > >> > >> =C2=A0(qemu) info kvm > >> =C2=A0kvm support: enabled > >> =C2=A0kvm version: kvm-85 > > > > =C2=A0Doesn't seem a good idea, as this is considered a stable protocol. > > > > =C2=A0Either, we should check current users or add 'info kvm-version'. >=20 > can't see why. We recently added information to info migrate, and many ot= hers. > If we are using a new line, shouldn't matter, since it is expected that p= arsers > for those things would be line based. I don't think this is a safe assumption if you take it literally for all the commands. If I remember correctly, libvirt for example, expects the string '(qemu)' as a meaning of 'command executed', in this case anything different could cause problems. I would have to check the code to be certain, though. But will not matter anyway, if 'info kvm' has no users. > Not only I'd like to see this, I would also like to see information of > kvm itself being > more verbose, like whether or not we have in kernel irqchip/pit Yes, this is really useful. I'm just concerned with current users and when I started working on the monitor protocol people have clearly expressed their concern on not changing commands output. I also should add that I would be extremely happy to find out that monitor's output could be changed. :)