qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Filip Navara <filip.navara@gmail.com>, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] make windows notice media change
Date: Wed, 29 Jul 2009 20:11:53 +0100	[thread overview]
Message-ID: <200907292011.54661.paul@codesourcery.com> (raw)
In-Reply-To: <20090729160902.GG30449@redhat.com>

> -    if (version_id != 2)
> +    if (version_id < 2)
>          return -EINVAL;

This is still wrong. You can not assume future versions will be backward 
compatible.

Paul

      parent reply	other threads:[~2009-07-29 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 16:09 [Qemu-devel] [PATCH v3] make windows notice media change Gleb Natapov
2009-07-29 17:10 ` Filip Navara
2009-07-29 17:38   ` Gleb Natapov
2009-07-29 18:43     ` Filip Navara
2009-07-29 20:12       ` Gleb Natapov
2009-07-29 21:04         ` Filip Navara
2009-07-30  3:51           ` Jamie Lokier
2009-07-30 11:54           ` Gleb Natapov
2009-07-29 19:11 ` Paul Brook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907292011.54661.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=filip.navara@gmail.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).